release-23.1: build,release: provide way to inject build tag override, use in MAPB #101998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #101943.
/cc @cockroachdb/release
When we build nightly builds, we build them in "release" configuration. Because we do this, the build tag reported by these binaries from
cockroach version
has been identical to that of an actual release binary, which is very confusing. Here we update the script to build these nightlies (make-and-publish-build-artifacts.sh
) to inject an appropriate, identifiable build tag.It is probably wrong that we are building these nightlies as if they were "releases". We'll follow up with work to fix this and refine the build tags further.
Closes #100532.
Epic: None
Release note (build change): Update reported
Build Tag
for nightly (non-release) buildsRelease justification: GA blocker