bazci,engflow: update bazel-github-helper to post issues for failures
#120352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickystewart
requested review from
srosenberg and
renatolabs
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rickystewart
force-pushed
the
post-failures-from-ci
branch
4 times, most recently
from
41de46b to
807f330
Compare
celiala
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Reviewed 59 of 59 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @renatolabs and @srosenberg)
We only post failures if we're on `master` or a release branch. This requires a refactor to move some common code into `pkg/build/engflow`. I also needed to move `pkg/cmd/internal/issues` to a different location to avoid restrictions related to `internal` packages. Epic: CRDB-8308 Release note: None
rickystewart
force-pushed
the
post-failures-from-ci
branch
from
807f330 to
7e9a753
Compare
|
TFTR! bors r=celiala |
|
Build succeeded: |
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Mar 18, 2024
This was accidentally regressed in cockroachdb#120352. Epic: CRDB-8308 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
120578: workflows: fetch extra commit needed for `TestRaftCopyrightHeaders` r=rail a=rickystewart Epic: CRDB-8308 Release note: None 120602: colexecargs: deeply reset monitor registry on Reset r=yuzefovich a=yuzefovich Given some recent issues we've had with leaks around memory monitors, it seems prudent to deeply reset the slice of monitors that is stored in the monitor registry object and is reused. Note that we haven't seen any evidence of leaks related to this registry, but this change might make things easier for GC, so seems worth it. Epic: None Release note: None 120650: bazci: only set extra params if provided on command-line r=rail a=rickystewart This was accidentally regressed in #120352. Epic: CRDB-8308 Release note: None 120651: sql/logictest: skip lookup_join_local under race r=mgartner a=mgartner Fixes #120609 Release note: None Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Marcus Gartner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only post failures if we're on
masteror a release branch.This requires a refactor to move some common code into
pkg/build/engflow. I also needed to movepkg/cmd/internal/issuesto a different location to avoid restrictions related to
internalpackages.
Epic: CRDB-8308
Release note: None