Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: make Linux EngFlow builds mandatory #120716

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

rickystewart
Copy link
Collaborator

We only delete the Linux ARM64 TeamCity build script because the others are still necessary for acceptance and local roachtest. When those builds are productionized on GitHub Actions, we can delete the other Linux build scripts as well.

Epic: CRDB-8308
Release note: None

@rickystewart rickystewart requested a review from rail March 19, 2024 20:03
@rickystewart rickystewart requested a review from a team as a code owner March 19, 2024 20:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart force-pushed the even-more-mandatory-builds branch from 2207c28 to adc42b3 Compare March 19, 2024 20:04
EXPERIMENTAL_linux_amd64_build:
runs-on: [self-hosted, basic_runner_group]
linux_amd64_build:
a runs-on: [self-hosted, basic_runner_group]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo. Otherwise LGTM

We only delete the Linux ARM64 TeamCity build script because the others
are still necessary for `acceptance` and local roachtest. When those
builds are productionized on GitHub Actions, we can delete the other
Linux build scripts as well.

Epic: CRDB-8308
Release note: None
@rickystewart rickystewart force-pushed the even-more-mandatory-builds branch from adc42b3 to 4bc7faf Compare March 21, 2024 18:57
@rickystewart
Copy link
Collaborator Author

TFTR!

bors r=rail

@craig craig bot merged commit f0c78f4 into cockroachdb:master Mar 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants