-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: make unit tests
build mandatory in GitHub Actions
#122048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b008080
to
e473af3
Compare
395d1f7
to
a190475
Compare
rail
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woooohoooo!!!!!
a190475
to
9275eef
Compare
And delete related TC scripts. Note that the unit tests job in GitHub Actions subsumes the unit test jobs in TC as well as the UI lint and UI test job. Epic: CRDB-8308 Release note: None
9275eef
to
c331a4d
Compare
bors r=rail |
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Apr 24, 2024
This was broken by cockroachdb#122048. Epic: none Release note: None
craig bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
122997: ui_test: fix AWS ui test build configuration r=celiala a=rickystewart This was broken by #122048. Epic: none Release note: None Co-authored-by: Ricky Stewart <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
This was broken by #122048. Epic: none Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And delete related TC scripts. Note that the unit tests job in GitHub Actions subsumes the unit test jobs in TC as well as the UI lint and UI test job.
Epic: CRDB-8308
Release note: None