Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: make unit tests build mandatory in GitHub Actions #122048

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

rickystewart
Copy link
Collaborator

And delete related TC scripts. Note that the unit tests job in GitHub Actions subsumes the unit test jobs in TC as well as the UI lint and UI test job.

Epic: CRDB-8308
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart added the backport-24.1.x Flags PRs that need to be backported to 24.1. label Apr 9, 2024
@rickystewart rickystewart force-pushed the all-builds-mandatory branch from b008080 to e473af3 Compare April 9, 2024 22:54
@rickystewart rickystewart force-pushed the all-builds-mandatory branch 2 times, most recently from 395d1f7 to a190475 Compare April 22, 2024 15:49
@rickystewart rickystewart requested a review from rail April 22, 2024 16:42
@rickystewart rickystewart marked this pull request as ready for review April 22, 2024 16:42
@rickystewart rickystewart requested a review from a team as a code owner April 22, 2024 16:42
Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooohoooo!!!!!

@rickystewart rickystewart force-pushed the all-builds-mandatory branch from a190475 to 9275eef Compare April 22, 2024 18:35
And delete related TC scripts. Note that the unit tests job in GitHub
Actions subsumes the unit test jobs in TC as well as the UI lint and UI
test job.

Epic: CRDB-8308
Release note: None
@rickystewart rickystewart force-pushed the all-builds-mandatory branch from 9275eef to c331a4d Compare April 23, 2024 19:39
@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig craig bot merged commit 7953760 into cockroachdb:master Apr 23, 2024
21 of 22 checks passed
rickystewart added a commit to rickystewart/cockroach that referenced this pull request Apr 24, 2024
This was broken by cockroachdb#122048.

Epic: none
Release note: None
craig bot pushed a commit that referenced this pull request Apr 24, 2024
122997: ui_test: fix AWS ui test build configuration r=celiala a=rickystewart

This was broken by #122048.

Epic: none
Release note: None

Co-authored-by: Ricky Stewart <[email protected]>
blathers-crl bot pushed a commit that referenced this pull request Apr 24, 2024
This was broken by #122048.

Epic: none
Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants