workload/tpcc: match against correct ErrNoRows in delivery txn #122903
Conversation
This has been broken since it was first added in fb9a8cd. The counter is used to perform audit checks 9.2.1.7: > Verify that no more than 1%, or no more than one (1), whichever is > greater, of the Delivery transactions skipped because there were fewer > than necessary orders present in the New-Order table. Epic: None Release note: None
Fixes cockroachdb#122891. `sql.ErrNoRows` is not the same as `pgx.ErrNoRows`. As a result, this logic has been broken since TPC-C was ported to use pgx in d15637c (2018). This commit fixes the broken logic by matching on the correct error. Release note: None
nvanbenschoten
requested review from
srosenberg and
DarrylWong
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @srosenberg)
|
TFTR! bors r=RaduBerinde |
|
blathers backport 23.1 23.2 24.1 |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 3e7a5cc to blathers/backport-release-23.1-122903: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1 failed. See errors above. error creating merge commit from 3e7a5cc to blathers/backport-release-23.2-122903: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2 failed. See errors above. error creating merge commit from 3e7a5cc to blathers/backport-release-24.1-122903: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes #122891.
sql.ErrNoRowsis not the same aspgx.ErrNoRows. As a result, this logic has been broken since TPC-C was ported to use pgx in d15637c (2018). This commit fixes the broken logic by matching on the correct error.Release note: None