prototype int8range #129233
Draft
prototype int8range #129233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128400: sqlstats/insights: fix mem leaks on session close r=xinhaoz a=xinhaoz insights: ensure releasing to Insight pool clears slice Ensure that when we return objects into the Insight pool that we release the statmeents in the slice. This fixes an issue in the logic that returned this object to the pool which did not nil the `Statements` slice, making it possible for these slices to grow in capacity in the node's lifetime, holding onto garbage Statement objects. This is a lead up to cockroachdb#128199 which will likely remove this pool and reuse the existing statmentBuf pool. Epic: none Release note: None insights: add testing knobs Add insights specific testing knobs. We'll add some knobs in later commts. Epic: none Release note: None sqlstats/insights: free memory allocated per session on session close The insights locking registry buffers statement insight objects by session id until receiving a transaction insight, when the buffer is emptied. These buffers can leak if the session is closed midway through a transaction since the registry will never receive a transaction event for the session. This commit ensures we clear any memory allocated in insights for a session by sending an event to clear the container's session entry, if it exists, on session close. A testing knob was added, OnCloseSession, which is called when the locking registry clears a session. Epic: none Fixes: cockroachdb#128213 Release note (bug fix): Fixes a memory leak where statement insight objects may leak if the session is closed without the transaction finishing. insights: move insights testing knobs from sqlstats Move some insights testing knobs that were on the sqlstats testing knobs to insights pkg. Epic: none Release note: None Co-authored-by: Xin Hao Zhang <[email protected]>
|
This change is |
Epic: none Release note: None
|
@ZhouXing19 and @sambhav-jain-16, it's a bit of a hack, but I added you both as reviewers to this fake PR so that hopefully you'll get email notifications whenever someone pushes to the branch |
ZhouXing19
force-pushed
the
rangetypes
branch
3 times, most recently
from
e31dd13 to
2d8489f
Compare
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
sambhav-jain-16
force-pushed
the
rangetypes
branch
from
80a3993 to
c1b1cb4
Compare
This reverts commit 82f4fb1.
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
You might see panic after a while after executing: root@localhost:26259/defaultdb> CREATE TABLE ab (a INT PRIMARY KEY, b INT8RANGE); CREATE TABLE Time: 21ms total (execution 21ms / network 1ms) root@localhost:26259/defaultdb> CREATE INDEX ON ab (b); CREATE INDEX Time: 652ms total (execution 652ms / network 0ms) root@localhost:26259/defaultdb> INSERT INTO ab VALUES (1, '[2,3)'::int8range); INSERT 0 1
This reverts commit 74bc516.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're building a prototype of range types for breather week! Starting with
int8range.Informs: #27791