Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: disallow ordering by VECTOR columns #131703

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Oct 1, 2024

Fixes #131573

Release note (bug fix): Ordering by VECTOR columns now results in an
"unimplemented" error. Previously it would result in internal errors in
some cases. See #92165.

@mgartner mgartner requested a review from a team as a code owner October 1, 2024 20:34
@mgartner mgartner requested review from mw5h and removed request for a team October 1, 2024 20:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner requested review from michae2 and a team October 1, 2024 20:34
@mgartner mgartner added the backport-24.2.x Flags PRs that need to be backported to 24.2 label Oct 1, 2024
Fixes cockroachdb#131573

Release note (bug fix): Ordering by `VECTOR` columns now results in an
"unimplemented" error. Previously it would result in internal errors in
some cases. See cockroachdb#92165.
@mgartner mgartner force-pushed the 131573-disk-spill-pgvector branch from 55f6d1b to ea61769 Compare October 2, 2024 13:24
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice!

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mw5h)

@mgartner
Copy link
Collaborator Author

mgartner commented Oct 5, 2024

TFTR!

bors r+

@craig craig bot merged commit 20466a6 into cockroachdb:master Oct 5, 2024
23 checks passed
Copy link

blathers-crl bot commented Oct 5, 2024

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #131573: branch-release-24.2.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link

blathers-crl bot commented Oct 5, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from ea61769 to blathers/backport-release-24.2-131703: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@mgartner mgartner deleted the 131573-disk-spill-pgvector branch October 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.2.x Flags PRs that need to be backported to 24.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: unoptimized-query-oracle/disable-rules=half/rand-tables failed
3 participants