jobs: produce SHOW JOBS without reading legacy info rows #138104
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
Here's a first peek at the read query to power crdb_internal.jobs without reading job_info. That said, this is default off -- and maybe doesn't merge -- until we get auth checks which I think will require rebasing on #138102, but I wanted to look at the query here in isolation, then talk about the auth checks once everything else is settled (maybe as a separate PR even). |
dt
requested review from
jeffswenson and
dhartunian
and removed request for
a team
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Okay, I've rebased this and made it on by default. Let's see what the tests think now. |
dt
force-pushed
the
jobs-vtable
branch
8 times, most recently
from
8ec3888 to
301b592
Compare
|
Only the last two commits here are outstanding; rest already merged. |
This isn't a very useful test: it is checking how SHOW JOBS handles invalid bytes in legacy_progress, which isn't something we actually need to account for (and changes when we don't read this row at all soon). Release note: none. Epic: none.
Release note (sql change): SHOW JOBS is now based on a new mechanism for storing information about the progress and status of running jobs. Epic: none.
|
TFTR! bors r+ |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-25.1-138104 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/139230/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 25.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
As of cockroachdb#138104, `fraction_completed` is NULL if there is no progress checkpoint for the job. Semantically, this is the right value. It's weird that jobs with a frontier like CDC jobs would start out with fraction_completed = 0 then switch to NULL once a checkpoint was recorded. Fixes: cockroachdb#139308 Part of: cockroachdb#139310 Release note: none
139359: roachtest: pause restore test should tolerate null fraction_completed r=jeffswenson a=jeffswenson As of #138104, `fraction_completed` is NULL if there is no progress checkpoint for the job. Semantically, this is the right value. It's weird that jobs with a frontier like CDC jobs would start out with fraction_completed = 0 then switch to NULL once a checkpoint was recorded. Fixes: #139308 Part of: #139310 Release note: none 139497: catalog/lease: deflake TestLeaseAtLatestVersion r=rafiss a=fqazi Currently, TestLeaseAtLatestVersion can flake when the initial version of a descriptor is acquired, which this test is not designed to handle. To address this, this patch will intentionally use a different database for the timestamp table, so that publishing a new version or a slow range feed does not acquire the kv table in the same schema. Fixes: #139386 Release note: None 139504: sql: avoid hangs in TestBackfillWithProtectedTS r=rafiss a=rafiss This test has been flaking. I haven't reproduced the failure yet, but this patch will at least make it so the test doesn't hang if an internal step fails, so we should be able to debug flakes more easily. informs #139281 informs #139493 Release note: None Co-authored-by: Jeff Swenson <[email protected]> Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
As of #138104, `fraction_completed` is NULL if there is no progress checkpoint for the job. Semantically, this is the right value. It's weird that jobs with a frontier like CDC jobs would start out with fraction_completed = 0 then switch to NULL once a checkpoint was recorded. Fixes: #139308 Part of: #139310 Release note: none
Release note: none.
Epic: none.