Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sql: add gauge for object count #138839

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

annrpom
Copy link
Contributor

@annrpom annrpom commented Jan 10, 2025

Backport 1/2 commits from #138786.

/cc @cockroachdb/release


This patch introduces a metric, sql.schema_changer.object_count, that
keeps track of the count of descriptors in the cluster.

Epic: none
Fixes: #134740

Release note (ops change): This patch introduces a metric,
sql.schema_changer.object_count, that keeps track of the count of
objects in the cluster.


Release justification: low-risk obs change

@annrpom annrpom requested a review from a team as a code owner January 10, 2025 17:52
Copy link

blathers-crl bot commented Jan 10, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 10, 2025
Copy link

blathers-crl bot commented Jan 10, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This patch introduces a metric, `sql.schema_changer.object_count`, that
keeps track of the count of descriptors in the cluster.

Epic: none
Fixes: cockroachdb#134740

Release note (ops change): This patch introduces a metric,
`sql.schema_changer.object_count`, that keeps track of the count of
objects in the cluster.
@annrpom annrpom force-pushed the backport24.1-138786 branch from cef099f to fba8622 Compare January 15, 2025 16:24
@annrpom annrpom merged commit ab3695a into cockroachdb:release-24.1 Jan 16, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants