sql: use parsed statements for persistedsqlstats #139171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, we would re-parse SQL statements used to upsert statement and txn stats. To address this patch, this patch will parse these statements once and use ExecParsed to reduce CPU usage. This patch also adds a simple benchmark for this code path as well, which shows a small 1% delta. Before: BenchmarkSQLStatsFlush 100 1415926687 ns/op 319339313 B/op 2302002 allocs/op After: BenchmarkSQLStatsFlush 100 1396673170 ns/op 319003310 B/op 2298192 allocs/op Fixes: cockroachdb#134583 Release note: None
fqazi
force-pushed
the
avoidFlushReparse
branch
from
2b2254d to
7362ad9
Compare
xinhaoz
approved these changes
Jan 16, 2025
|
@xinhaoz TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would re-parse SQL statements used to upsert statement and txn stats. To address this patch, this patch will parse these statements once and use ExecParsed to reduce CPU usage. This patch also adds a simple benchmark for this code path as well, which shows a small 1% delta.
Before:
BenchmarkSQLStatsFlush 100 1415926687 ns/op 319339313 B/op 2302002 allocs/op
After:
BenchmarkSQLStatsFlush 100 1396673170 ns/op 319003310 B/op 2298192 allocs/op
Fixes: #134583
Release note: None