Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: update build from source link #139257

Merged
merged 1 commit into from
Jan 16, 2025
Merged

README: update build from source link #139257

merged 1 commit into from
Jan 16, 2025

Conversation

dhartunian
Copy link
Collaborator

Release note: None

@dhartunian dhartunian requested a review from dt January 16, 2025 20:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

dt
dt approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@dt dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@dhartunian
Copy link
Collaborator Author

bors r+

@rickystewart rickystewart added backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 backport-25.1.x Flags PRs that need to be backported to 25.1 labels Jan 16, 2025
@rickystewart
Copy link
Collaborator

Added backport labels just to cover our bases -- if you want, you can remove them.

@craig
Copy link
Contributor

craig bot commented Jan 16, 2025

Build succeeded:

@craig craig bot merged commit 5b61a0e into cockroachdb:master Jan 16, 2025
21 of 22 checks passed
This was referenced Jan 16, 2025
Open
Open
Open
Open
Open
@dt
Copy link
Member

dt commented Jan 16, 2025

backport labels

I imagine most users clicking this link are doing so by just visiting the repository’s landing page and clicking it rather than navigating to specific branches so I don’t know that the backports are particularly essential but 🤷

@rickystewart
Copy link
Collaborator

rickystewart commented Jan 16, 2025 •
edited
Loading

Yeah, doesn't strike me as important, but it's conceivable someone could be confused about it somewhere down the line and it costs us very little to just backport it now while it's fresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickystewart rickystewart rickystewart approved these changes

@dt dt dt approved these changes

Assignees
No one assigned
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 backport-25.1.x Flags PRs that need to be backported to 25.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhartunian @cockroach-teamcity @rickystewart @dt