Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-deps: bump jemalloc version #139260

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicktrav
Copy link
Collaborator

@nicktrav nicktrav commented Jan 16, 2025

Bump the version of jemalloc from jemalloc/jemalloc@54eaed1 (5.3.0) to jemalloc/jemalloc@17881eb (tip of dev at time of commit).

Commit log of changes can be generated with the following:

$ cd ./cdeps/jemalloc
$ git log --pretty='format:%C(auto)%h (%as) %s' 54eaed1..17881eb

The full diff of changes can be found here.

Release note (general change): The version of jemalloc (the memory allocator that CRDB uses) to the latest version. This pulls in a number of upstream fixes and improvements.

Epic: None.

Bump the version of jemalloc from
jemalloc/jemalloc@54eaed1 (`5.3.0`) to
jemalloc/jemalloc@17881eb (tip of `dev`
at time of commit).

Commit log of changes can be generated with the following:

```
$ cd ./cdeps/jemalloc
$ git log --pretty='format:%C(auto)%h (%as) %s' 54eaed1..17881eb
```

The full diff of changes can be found [here](https://github.com/jemalloc/jemalloc/compare/54eaed1..17881eb).

Release note (general change): The version of jemalloc (the memory
allocator that CRDB uses) to the latest version. This pulls in a number
of upstream fixes and improvements.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nicktrav
Copy link
Collaborator Author

@rickystewart - would you be able to weave your magic here and generate the c-deps?

@rickystewart
Copy link
Collaborator

Give me an hour or so.

@rickystewart
Copy link
Collaborator

Is 17881ebbfd76529904e826f425f3266834cf3a75 not pushed? The build is failing.

@nicktrav
Copy link
Collaborator Author

Should be good now. I see the rev there on the dev branch of our fork.

@rickystewart
Copy link
Collaborator

OK, I've kicked off the build, please wait until Tuesday and I'll send you a patch.

@rickystewart
Copy link
Collaborator

Looks like the build fails now:

23:58:31 src/prof_sys.c:143:1: error: unknown warning group '-Wframe-address', ignored [-Werror,-Wunknown-warning-option]
23:58:31 JEMALLOC_DIAGNOSTIC_IGNORE_FRAME_ADDRESS
23:58:31 ^
23:58:31 include/jemalloc/internal/jemalloc_internal_macros.h:87:6: note: expanded from macro 'JEMALLOC_DIAGNOSTIC_IGNORE_FRAME_ADDRESS'
23:58:31 JEMALLOC_DIAGNOSTIC_IGNORE("-Wframe-address")
23:58:31 ^
23:58:31 include/jemalloc/internal/jemalloc_internal_macros.h:71:6: note: expanded from macro 'JEMALLOC_DIAGNOSTIC_IGNORE'
23:58:31 JEMALLOC_PRAGMA__(GCC diagnostic ignored W)
23:58:31 ^
23:58:31 include/jemalloc/internal/jemalloc_internal_macros.h:67:32: note: expanded from macro 'JEMALLOC_PRAGMA__'
23:58:31 # define JEMALLOC_PRAGMA__(X) _Pragma(#X)
23:58:31 ^
23:58:31 :123:25: note: expanded from here
23:58:31 GCC diagnostic ignored "-Wframe-address"

@RaduBerinde
Copy link
Member

I am a bit hesitant to switch to something that doesn't have a release. Part of it is that probably not many other jemalloc users are using the dev branch so we may be the first to hit an issue.
It's a tradeoff so we should figure out if any of the new commits are a significant improvement that we really want.

@nicktrav
Copy link
Collaborator Author

@RaduBerinde - sounds good. Let me at least get this building, so we can take it for a spin, and we can make a call then. Looks like there's some breakage that we'll need to understand / fix anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants