Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: skip MR configs under race outside ccl #139299

Merged
merged 1 commit into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/cmd/generate-logictest/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type testFileTemplateConfig struct {
CockroachGoTestserverTest bool
Ccl bool
ForceProductionValues bool
SkipCclUnderRace bool
SkipUnderRace bool
UseHeavyPool useHeavyPoolCondition
Package, TestRuleName, RelDir string
ConfigIdx int
Expand Down Expand Up @@ -188,7 +188,7 @@ func (t *testdir) dump() error {
tplCfg.NumCPU = 3
}
if cfg.Name == "3node-tenant" || strings.HasPrefix(cfg.Name, "multiregion-") {
tplCfg.SkipCclUnderRace = true
tplCfg.SkipUnderRace = true
}
tplCfg.UseHeavyPool = useHeavyPoolNever
if strings.Contains(cfg.Name, "5node") ||
Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/generate-logictest/templates.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const templateText = `
{{- define "runLogicTest" }}
{{- if .LogicTest -}}
func runLogicTest(t *testing.T, file string) {
{{if and .SkipCclUnderRace .Ccl}}skip.UnderRace(t, "times out and/or hangs")
{{if .SkipUnderRace}}skip.UnderRace(t, "times out and/or hangs")
{{end}}skip.UnderDeadlock(t, "times out and/or hangs")
logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(logicTestDir, file))
}
Expand All @@ -48,7 +48,7 @@ func runLogicTest(t *testing.T, file string) {
{{- define "runCCLLogicTest" }}
{{- if .CclLogicTest -}}
func runCCLLogicTest(t *testing.T, file string) {
{{if .SkipCclUnderRace}}skip.UnderRace(t, "times out and/or hangs")
{{if .SkipUnderRace}}skip.UnderRace(t, "times out and/or hangs")
{{end}}skip.UnderDeadlock(t, "times out and/or hangs")
logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file))
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading