Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: roachtest: collect qps metrics over longer window in gracefuldrain test #139458

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

arulajmani
Copy link
Collaborator

Backport 1/1 commits from #139273.

/cc @cockroachdb/release


The gracefuldrain test was modernized in cf30717. Prior to that commit, QPS metrics were collected over a 10s interval, whereas the modernization refactor changed this to 1 second intervals. Looking at a few recent test failures, I see QPS metrics above the failure threshold, which makes me think suspect that this 1s interval is causing the sorts of inaccuracies MeasureQPS warns against. Also See #133020 (comment).

One thing that doesn't line up is the timeline of this tests failure and cf30717. Still, this patch changes the metric's interval back to 10s.

References #133020

Release note: None

The gracefuldrain test was modernized in cf30717.
Prior to that commit, QPS metrics were collected over a 10s interval,
whereas the modernization refactor changed this to 1 second intervals.
Looking at a few recent test failures, I see QPS metrics above the failure
threshold, which makes me think suspect that this 1s interval is causing
the sorts of inaccuracies MeasureQPS warns against.
Also See cockroachdb#133020 (comment).

One thing that doesn't line up is the timeline of this tests failure and
cf30717. Still, this patch changes the
metric's interval back to 10s.

References cockroachdb#133020

Release note: None
@arulajmani arulajmani requested a review from iskettaneh January 20, 2025 19:45
Copy link

blathers-crl bot commented Jan 20, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 20, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@arulajmani arulajmani merged commit f701b68 into cockroachdb:release-24.2 Jan 20, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants