Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cli: validate input file in tsdump command #139731

Merged
merged 1 commit into from
Jan 27, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions pkg/cli/tsdump.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ will then convert it to the --format requested in the current invocation.
}

var w tsWriter
switch debugTimeSeriesDumpOpts.format {
switch cmd := debugTimeSeriesDumpOpts.format; cmd {
case tsDumpRaw:
if convertFile != "" {
return errors.Errorf("input file is already in raw format")
Expand All @@ -104,30 +104,19 @@ will then convert it to the --format requested in the current invocation.
10_000_000, /* threshold */
doRequest,
)
case tsDumpDatadog:
targetURL, err := getDatadogTargetURL(debugTimeSeriesDumpOpts.ddSite)
if err != nil {
return err
case tsDumpDatadogInit, tsDumpDatadog:
if len(args) < 1 {
return errors.New("no input file provided")
}

var datadogWriter = makeDatadogWriter(
targetURL,
false,
debugTimeSeriesDumpOpts.ddApiKey,
100,
doDDRequest,
)
return datadogWriter.upload(args[0])

case tsDumpDatadogInit:
targetURL, err := getDatadogTargetURL(debugTimeSeriesDumpOpts.ddSite)
if err != nil {
return err
}

var datadogWriter = makeDatadogWriter(
targetURL,
true,
cmd == tsDumpDatadogInit,
debugTimeSeriesDumpOpts.ddApiKey,
100,
doDDRequest,
Expand Down
Loading