kvclient: introduce txnWriteBuffer interceptor #139742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
This patch introduces a new txn interceptor to the TxnCoordSender's interceptor stack -- the txnWriteBuffer. This commit is mostly boilerplate code with some forward looking commentary, so for now, the interceptor is as no-op as it gets. Soon, we'll expand this to actually introduce client side write buffering. References cockroachdb#139053 Release note: None
arulajmani
force-pushed
the
bw-txn-interceptor
branch
from
e8c6983 to
c1a974b
Compare
|
TFTR! bors r=stevendanna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new txn interceptor to the TxnCoordSender's interceptor stack -- the txnWriteBuffer. This commit is mostly boilerplate code with some forward looking commentary, so for now, the interceptor is as no-op as it gets. Soon, we'll expand this to actually introduce client side write buffering.
References #139053
Release note: None