cdctest: use legacy schema changer when sql smith is enabled #139914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
aerfrei
approved these changes
Jan 28, 2025
| withLegacySchemaChanger := maybeDisableDeclarativeSchemaChangesForTest(t, sqlDB) | ||
|
|
||
| v, err := cdctest.RunNemesis(f, s.DB, t.Name(), withLegacySchemaChanger, rng, nop) | ||
| disable := nop.EnableSQLSmith || rng.Float32() < 0.1 |
There was a problem hiding this comment.
In this context, I would want to name "disable" something more descriptive, maybe keeping it as "withLegacySchemaChanger"
| @@ -25,17 +25,18 @@ func TestChangefeedNemeses(t *testing.T) { | |||
| skip.UnderRace(t, "takes >1 min under race") | |||
|
|
|||
| testutils.RunValues(t, "nemeses_options=", cdctest.NemesesOptions, func(t *testing.T, nop cdctest.NemesesOption) { | |||
| if nop.EnableSQLSmith == true { | |||
| skip.WithIssue(t, 137125) | |||
There was a problem hiding this comment.
Is there a way to note that this is a temporary fix with a comment or TODO or something. Before, this line linked it to this issue (137125). Is it worth keeping another pointer to that issue?
This patch disables the declarative schema changer when TestChangefeedNemeses uses SQLSmith. Enabling it causes a decoder error, so it is temporarily disabled as a workaround. This ensures nemesis testing can run in CI with SQLSmith without being skipped. Informs: cockroachdb#137125 Release note: None
wenyihu6
requested review from
rharding6373
and removed request for
a team and
rharding6373
|
Extended CI failed under stress due to timeouts not related to this bug fix. TFTR! bors r=aerfrei |
craig bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
139914: cdctest: use legacy schema changer when sql smith is enabled r=aerfrei a=wenyihu6 This patch disables the declarative schema changer when TestChangefeedNemeses uses SQLSmith. Enabling it causes a decoder error, so it is temporarily disabled as a workaround. This ensures nemesis testing can run in CI with SQLSmith without being skipped. Informs: #137125 Release note: None 139959: go.mod: bump Pebble to 1157615755bc r=RaduBerinde a=jbowens Changes: * [`11576157`](cockroachdb/pebble@11576157) db: add optional ValidateKey Comparer func * [`303c8855`](cockroachdb/pebble@303c8855) metamorphic: fix time-bound filtering * [`89cae40f`](cockroachdb/pebble@89cae40f) Update stale comment in comparer.go * [`a4761ee8`](cockroachdb/pebble@a4761ee8) cache: readShard: use a separate mutex * [`16466355`](cockroachdb/pebble@16466355) cockroachkvs: pull in MVCC block-property collector, filter * [`2fa3b969`](cockroachdb/pebble@2fa3b969) internal/metamorphic: fix bugs in KeyFormat abstraction * [`6c523bfb`](cockroachdb/pebble@6c523bfb) metamorphic: ignore rangedels for deduplicating point prefixes Release note: none. Epic: none. Co-authored-by: Wenyi Hu <[email protected]> Co-authored-by: Jackson Owens <[email protected]>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
139265: opt: remove incorrect query plans for trigram similarity filters r=normanchenn a=normanchenn Previously, the optimizer would produce incorrect query plans for queries with trigram similarity filters when `pg_trgm.similarity_threshold == 0`, producing incorrect results. To address this, this patch adds a check to return early if `pg_trgm.similarity_threshold == 0` in trigram similarity queries on inverted indices. Fixes: #122443 Release note (bug fix): The optimizer could produce incorrect query plans for queries using trigram similarity filters (e.g. `col % 'val'`) when `pg_trgm.similarity_threshold` was set to 0. This bug was introduced in v22.2.0 and is now fixed. Note that this issue does not affect v24.2.0+ releases when the `optimizer_use_trigram_similarity_optimization` session variable (introduced in v24.2.0) is set to its default value `true`, as it would skip this behaviour. 139914: cdctest: use legacy schema changer when sql smith is enabled r=aerfrei a=wenyihu6 This patch disables the declarative schema changer when TestChangefeedNemeses uses SQLSmith. Enabling it causes a decoder error, so it is temporarily disabled as a workaround. This ensures nemesis testing can run in CI with SQLSmith without being skipped. Informs: #137125 Release note: None Co-authored-by: Norman Chen <[email protected]> Co-authored-by: Wenyi Hu <[email protected]>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
139914: cdctest: use legacy schema changer when sql smith is enabled r=aerfrei a=wenyihu6 This patch disables the declarative schema changer when TestChangefeedNemeses uses SQLSmith. Enabling it causes a decoder error, so it is temporarily disabled as a workaround. This ensures nemesis testing can run in CI with SQLSmith without being skipped. Informs: #137125 Release note: None Co-authored-by: Wenyi Hu <[email protected]>
|
Build failed: |
|
bors retry |
craig bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
139914: cdctest: use legacy schema changer when sql smith is enabled r=aerfrei a=wenyihu6 This patch disables the declarative schema changer when TestChangefeedNemeses uses SQLSmith. Enabling it causes a decoder error, so it is temporarily disabled as a workaround. This ensures nemesis testing can run in CI with SQLSmith without being skipped. Informs: #137125 Release note: None Co-authored-by: Wenyi Hu <[email protected]>
|
Build failed: |
|
Unit tests failures seem unrelated and are known flakes. bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disables the declarative schema changer when TestChangefeedNemeses
uses SQLSmith. Enabling it causes a decoder error, so it is temporarily disabled
as a workaround. This ensures nemesis testing can run in CI with SQLSmith
without being skipped.
Informs: #137125
Release note: None