kvclient: add a btree to store buffered writes #139963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
arulajmani
force-pushed
the
bw-introduce-buffer
branch
from
0a952af to
003dc50
Compare
stevendanna
approved these changes
Jan 29, 2025
arulajmani
force-pushed
the
bw-introduce-buffer
branch
from
003dc50 to
132a314
Compare
This patch introduces a btree to buffer writes on the txnWriteBuffer interceptor. References cockroachdb#139053 Release note: None
arulajmani
force-pushed
the
bw-introduce-buffer
branch
from
132a314 to
aa0efb6
Compare
|
TFTR! I had to do some hacky stuff to calm down static check, but that should go away once the next PR is in. bors r=stevendanna |
craig bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
140001: kvclient: buffer blind writes on the client r=stevendanna,yuzefovich a=arulajmani First commit from #139963. ---- This patch adds logic to buffer blind writes (Puts or Deletes) in the txnWriteBuffer. Interceptors and layers above remain oblivious to the txnWriteBuffer's decision to buffer any writes. All buffered writes are flushed at commit time, in the same batch as the EndTxn request. This flushing at commit time is also hidden from interceptors above the txnWriteBuffer by stripping responses on the return path. The code structure here allows us to split a batch request into different bits, where some portion is evaluated locally and the rest is sent to the KV layer. It's written with a future where we split read-write requests (e.g. CPuts) into separte read/write halves, where the read portion needs to be evaluated at the leaseholder, but the write needs to be buffered. Closes #139053 Release note: None Co-authored-by: Arul Ajmani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a btree to buffer writes on the txnWriteBuffer interceptor.
References #139053
Release note: None