Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: workload/schemachanger: handle not null violations for new tables #141457

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 13, 2025

Backport 1/1 commits from #141431 on behalf of @fqazi.

/cc @cockroachdb/release


The workload previously assumed that NOT NULL constraint violations would only occur during the commit phase of ALTER COLUMN... SET NULL statements. However, these errors can also occur during statement execution for newly created tables. This patch addresses this issue by adding NOT NULL violation errors to the list of potential execution errors.

Fixes: #139816
Release note: None


Release justification: test only change

The workload previously assumed that NOT NULL constraint violations
would only occur during the commit phase of  ALTER COLUMN... SET NULL
statements. However, these errors can also occur during statement
execution for newly created tables. This patch addresses this issue by
adding NOT NULL violation errors to the list of potential execution
errors.

Fixes: #139816
Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-141431 branch from c23641e to 822ce16 Compare February 13, 2025 22:42
@blathers-crl blathers-crl bot requested a review from a team as a code owner February 13, 2025 22:42
@blathers-crl blathers-crl bot requested review from srosenberg and golgeek and removed request for a team February 13, 2025 22:42
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 13, 2025
@blathers-crl blathers-crl bot requested review from DarrylWong and rafiss February 13, 2025 22:42
Copy link
Author

blathers-crl bot commented Feb 13, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 13, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit ecf2a9b into release-24.3 Feb 19, 2025
15 of 16 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.3-141431 branch February 19, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-24.3.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants