Pick up coreos/etcd#8689 #27998
Merged
Pick up coreos/etcd#8689 #27998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This picks up etcd-io/etcd#8689. Release note: None
|
This change is |
|
Nice, LGTM |
|
TFTR. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 30, 2018
27998: Pick up etcd-io/etcd#8689 r=nvanbenschoten a=nvanbenschoten This picks up etcd-io/etcd#8689. Release note: None 28002: storage: avoid double lock in tryGetOrCreateReplica r=nvanbenschoten a=nvanbenschoten Before this change, `tryGetOrCreateReplica` was RLocking, checking an uncommon condition, then Locking. This was unnecessary and made the code look strange. It also resulted in an extra RLock in the exceptionally common case where the Replica was not destroyed. This change fixes this by collapsing the destroyStatus check into the main critical section. There's no real expected performance improvement here, this is mostly just for cleaner code. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up etcd-io/etcd#8689.
Release note: None