Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove an UnexpectedWithIssueErrorf #30563

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

andreimatei
Copy link
Contributor

Since the respective issue has been closed.
Touches #12876

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r-

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@craig
Copy link
Contributor

craig bot commented Sep 24, 2018

Canceled

@andreimatei andreimatei force-pushed the UnexpectedWithIssueErrorf branch from bad7b57 to 683430a Compare September 25, 2018 00:19
@andreimatei andreimatei requested a review from a team September 25, 2018 00:19
@andreimatei andreimatei force-pushed the UnexpectedWithIssueErrorf branch 3 times, most recently from 8cf8e0e to d3eaf6b Compare September 25, 2018 01:11
Since the respective issue has been closed.
Touches cockroachdb#12876

Release note: None
@andreimatei andreimatei force-pushed the UnexpectedWithIssueErrorf branch from d3eaf6b to 9dcae4a Compare September 25, 2018 01:15
Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

craig bot pushed a commit that referenced this pull request Sep 25, 2018
30563: sql: remove an UnexpectedWithIssueErrorf r=andreimatei a=andreimatei

Since the respective issue has been closed.
Touches #12876

Release note: None

Co-authored-by: Andrei Matei <[email protected]>
@craig
Copy link
Contributor

craig bot commented Sep 25, 2018

Build succeeded

@craig craig bot merged commit 9dcae4a into cockroachdb:master Sep 25, 2018
@andreimatei andreimatei deleted the UnexpectedWithIssueErrorf branch September 25, 2018 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants