[DNM] opt: prototype bypass planNode for Scan #30969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proof-of-concept for how we can bypass creation of planNodes and create the distSQL plan directly from the execbuilder. Bypassing creation of the planNode saves 3.6% in total execution time for the query `SELECT * FROM kv`. name old time/op new time/op delta Exec/kv-scan/ExecOpt 247µs ± 3% 238µs ± 1% -3.64% It would be ideal to avoid using the interface in the execbuilder that was needed to create planNodes in the sql package, but creation of distSQL nodes is also heavily intertwined with the sql package. Moving the new opt_distsql_factory into opt should probably be a long-term goal, but it would be quite difficult in the short term without duplicating a lot of code. Release note: None
|
This change is |
59 tasks
|
Keeping this open is no longer useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept for how we can bypass creation of
planNodes and create the distSQL plan directly from the execbuilder.
Bypassing creation of the planNode saves 3.6% in total execution time
for the query
SELECT * FROM kv.It would be ideal to avoid using the interface in the execbuilder
that was needed to create planNodes in the sql package, but creation
of distSQL nodes is also heavily intertwined with the sql package.
Moving the new opt_distsql_factory into opt should probably be a
long-term goal, but it would be quite difficult in the short term
without duplicating a lot of code.
Release note: None