backport-2.1: sql: fix deadlock in VALIDATE CONSTRAINT #32850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is present because of the call to the InternalExecutor which has a limitation that while it can reuse a user transaction it cannot reuse a TableCollection associated with a transaction. Therefore if a user runs a schema change before a VALIDATE in the same transaction the transaction can get deadlocked on: the transaction having an outstanding intent on the table, and the InternalExecutor triggering a table lease acquisition on the table. Stop using the InternalExecutor in VALIDATE CONSTRAINT. Added the missing call to rows.Close() in validateCheckExpr() related to cockroachdb#32118 Release note (sql change): Fix deadlock when using ALTER TABLE VALIDATE CONSTRAINT in a transaction with a schema change.
|
This change is |
dt
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #32772.
/cc @cockroachdb/release
This is present because of the call to the InternalExecutor
which has a limitation that while it can reuse a user transaction
it cannot reuse a TableCollection associated with a transaction.
Therefore if a user runs a schema change before a VALIDATE
in the same transaction the transaction can get deadlocked on:
the transaction having an outstanding intent on the table, and
the InternalExecutor triggering a table lease acquisition on the
table.
Stop using the InternalExecutor in VALIDATE CONSTRAINT.
Added the missing call to rows.Close() in validateCheckExpr()
related to #32118
Release note (sql change): Fix deadlock when using
ALTER TABLE VALIDATE CONSTRAINT in a transaction with a schema change.