roachtest: update hibernate blacklist for 19.1 and 19.2 #40479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blacklist was missing some expected failures and also incorrectly marked some tests as expected failure. Some of them are a result of Hibernate adding new tests to their repository. Closing cockroachdb#6583 revealed a few new compatibility issues, so many of the failing tests now link to a new issue. Release note: None
|
This change is |
|
LGTM |
|
bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Sep 5, 2019
40479: roachtest: update hibernate blacklist for 19.1 and 19.2 r=rafiss a=rafiss The blacklist was missing some expected failures and also incorrectly marked some tests as expected failure. Some of them are a result of Hibernate adding new tests to their repository. Closing #6583 revealed a few new compatibility issues, so many of the failing tests now link to a new issue. closes #38288 Release note: None Co-authored-by: Rafi Shamim <[email protected]>
Build succeeded |
|
Remember that we support three versions back, so we should've updated 2.1 and 2.0 whitelists too (or mark this test as skipped on those versions). Many of the "expected failures" added in this PR failed in the 2.1.9 qualification build: https://teamcity.cockroachdb.com/viewLog.html?buildId=1493878&buildTypeId=Cockroach_Nightlies_WorkloadNightly |
rafiss
added a commit
to rafiss/cockroach
that referenced
this pull request
Sep 23, 2019
New tests were added to the Hibernate testing suite. These blacklists should have been updated in cockroachdb#40479 but were not. relates to cockroachdb#40977 Release justification: This is a testing-only change. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 26, 2019
40985: roachtest: update hibernate blacklists for 2.1 and 2.0 r=jordanlewis a=rafiss New tests were added to the Hibernate testing suite. These blacklists should have been updated in #40479 but were not. relates to #40977 Release justification: This is a testing-only change. Release note: None 41071: sql/row: support IMPORT of tables with multiple column families r=dt a=danhhz When importing a table with multiple column families, if one of the families is all NULL, we omit it from KV. A delete is issued to remove the previous value of that column family. This was previously hitting an unimplemented panic when used with IMPORT. This delete is called when there are multiple column families to ensure that existing data is cleared. With the exception of IMPORT INTO, the entire existing keyspace in any IMPORT is guaranteed to be empty, so we don't have to worry about it. IMPORT INTO disallows overwriting an existing row, so we're also okay here. The reason this works is that row existence is precisely defined as whether column family 0 exists, meaning that we write column family 0 even if all the non-pk columns in it are NULL. It follows that either the row does exist and the imported column family 0 will conflict (and the IMPORT INTO will fail) or the row does not exist (and thus the column families are all // empty). Closes #41004 Release note (bug fix): `workload init ycsb` now works with `--data-loader=import` Release justification: Low risk update to fix "--data-loader=import" when used with ycsb workload Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Daniel Harrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blacklist was missing some expected failures and also incorrectly
marked some tests as expected failure. Some of them are a result of
Hibernate adding new tests to their repository.
Closing #6583 revealed a few new compatibility issues, so many of the
failing tests now link to a new issue.
closes #38288
Release note: None