Revert "sql: add support for max/min aggregates on collated strings" #46693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Reverts #46647 As brought up by #46685, the simple change in #46647 is not enough. An investigation into why makes it seem like we need a decent refactor of the overload return type system. Because we type this aggregate with types.AnyCollatedStringFamily, we don't end up propagating the correct return type (the collation of the input) through to receivers of the aggregate's output. I think it is too late in the release to attempt such a refactor, so I'm going to revert this PR. Release justification: Reverts a bug. Release note (sql change): Remove the ability to perform min/max aggregates on collated strings.
rohany
force-pushed
the
revert-46647-collated-string-max-min
branch
from
4fa1ab0 to
47f4996
Compare
yuzefovich
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Please also reopen the original issue.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rohany)
pkg/sql/rowexec/version_history.txt, line 112 at r1 (raw file):
by older nodes. However, new nodes can process plans from older nodes, so MinAcceptedVersion is unchanged. - Version: 29 (MinAcceptedVersion: 29)
Could you make sure that this commit wasn't included in any of the betas?
|
bors r=yuzefovich |
Build failed (retrying...) |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #46647
As brought up by #46685, the simple change in #46647 is not enough. An investigation into why makes it seem like we need a decent refactor of the overload return type system. Because we type this aggregate with
types.AnyCollatedStringFamily, we don't end up propagating the correct return type (the collation of the input) through to receivers of the aggregate's output. I think it is too late in the release to attempt such a refactor, so I'm going to revert this PR.Release justification: Reverts a bug.
Release note (sql change): Remove the ability to perform min/max aggregates on collated strings.