colexec: clean up materializer a bit #48548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
May 12, 2020
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
Merge conflict (retrying...) |
|
bors r- |
Canceled |
While working on cfetcher + materializer instead of table reader, I noticed something weird - that we get `OutputTypes` in the materializer, and use those when converting physical vectors to datums. I thought this was a bug because `OutputTypes` returns the type schema after post-processing stage, and internal type schema of a processor could be different. It turns out we simply always pass in empty `PostProcessSpec` into the materializer because we expect the input operator to handle the post-processing itself. This commit cleans it up by removing that unused argument and the call to `ProcessRowHelper`. Release note: None
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on cfetcher + materializer instead of table reader,
I noticed something weird - that we get
OutputTypesin thematerializer, and use those when converting physical vectors to datums.
I thought this was a bug because
OutputTypesreturns the type schemaafter post-processing stage, and internal type schema of a processor
could be different. It turns out we simply always pass in empty
PostProcessSpecinto the materializer because we expect the inputoperator to handle the post-processing itself. This commit cleans it up
by removing that unused argument and the call to
ProcessRowHelper.Release note: None