roachtest: fix typo in tpchvec/perf #49554
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @yuzefovich)
pkg/cmd/roachtest/tpchvec.go, line 270 at r1 (raw file):
for i := 0; i < tpchPerfTestNumRunsPerQuery; i++ { rows, err := conn.Query(fmt.Sprintf( "EXPLAIN ANALYZE %s;", tpch.QueriesByNumber[queryNum],
Does a double semi-colon matter? I would try this out by modifying it to always run EXPLAIN ANALYZE and running the roachtest locally to make sure it works so we avoid any other problems of this type.
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tpchvec.go, line 270 at r1 (raw file):
Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
Does a double semi-colon matter? I would try this out by modifying it to always run EXPLAIN ANALYZE and running the roachtest locally to make sure it works so we avoid any other problems of this type.
I tried it out in the cli, and an extra semicolon didn't matter, but I'll run the roachtest to confirm that.
TPCH queries have semicolon at the end, so when trying to do `SELECT url FROM [EXPLAIN ANALYZE %s];` with query replacing the `%s`, we would have a semicolon within square brackets which would produce a syntax error. Fix this by reading both `automatic` boolean and `url` string and outputting the latter. Release note: None
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tpchvec.go, line 270 at r1 (raw file):
Previously, yuzefovich wrote…
I tried it out in the cli, and an extra semicolon didn't matter, but I'll run the roachtest to confirm that.
The manual run actually showed that there was a problem with closing of rows - initially I had defer rows.Close() which would leave conn in "unfinished" state because I do not call rows.Next() until it returns false - i.e. until exhaustion. I modified the code a bit, and then everything worked as expected.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
|
TFTR! bors r+ |
Build failed (retrying...) |
Build succeeded |
TPCH queries have semicolon at the end, so when trying to do
SELECT url FROM [EXPLAIN ANALYZE %s];with query replacing the%s, we would havea semicolon within square brackets which would produce a syntax error.
Fix this by reading both
automaticboolean andurlstring andoutputting the latter.
Release note: None