geo/geomfn: implement ST_Centroid for Geometry and string #49613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Also had to add hacks in to handle `POINT EMPTY` decoding -- this is currently a problem with both GEOS and twpayne/go-geom, which I have circumvented for now. An issue has been filed to track this. Release note (sql change): Implement the ST_Centroid builtin which works for Geometry and string arguments.
sumeerbhola
approved these changes
May 28, 2020
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r=sumeerbhola |
Build failed (retrying...) |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also had to add hacks in to handle
POINT EMPTYdecoding -- this iscurrently a problem with both GEOS and twpayne/go-geom, which I have
circumvented for now. An issue has been filed to track this.
Resolves #48893.
Resolves #48805.
Release note (sql change): Implement the ST_Centroid builtin which works
for Geometry and string arguments.