backupccl: stop reading on MutationJobs on RESTORE #51848
Conversation
pbardea
requested review from
thoszhang,
a team and
dt
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @lucy-zhang)
There was a problem hiding this comment.
what's up with the proto generated changes?
Reviewable status:
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:
pbardea
force-pushed
the
backup-mutations
branch
from
ce8b747 to
0625f05
Compare
pbardea
force-pushed
the
backup-mutations
branch
2 times, most recently
from
22465c4 to
6490d21
Compare
|
@lucy-zhang made a small change to handle migrating when several mutations share the same mutation ID. Before when looking at mutation jobs, these mutations would only have 1 corresponding job so I'm now keeping track of the mutations we've seen as to not re-create the same mutation job twice. |
There was a problem hiding this comment.
lgtm, modulo the pb.gw.go file changes
Reviewed 5 of 5 files at r2.
Reviewable status:
This change stops reading the MutationJobs field on table descriptors that we are importing. It previously assumed that the MutationsJobs and Mutations remain in sync. However, in practice there are descriptors where this is not the case and RESTORE should no longer rely on this assumption. Release note (bug fix): Increase robustness of restore against descriptors which may be in an unexpected state.
pbardea
force-pushed
the
backup-mutations
branch
from
6490d21 to
83218f1
Compare
|
TFTR |
|
Build failed: |
|
Flaked on #51356. |
|
Build failed (retrying...): |
|
Build failed: |
|
Flaked on #49895. |
|
Build succeeded: |
This change stops reading the MutationJobs field on table descriptors
that we are importing. It previously assumed that the MutationsJobs and
Mutations remain in sync. However, in practice there are descriptors
where this is not the case and RESTORE should no longer rely on this
assumption.
Release note (bug fix): Increase robustness of restore against
descriptors which may be in an unexpected state.