sql: implement ConstructOpaque in the new factory #52163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
distsql-plannodes
branch
2 times, most recently
from
73c8f87 to
a83698b
Compare
yuzefovich
changed the title
Release note: None
yuzefovich
force-pushed
the
distsql-plannodes
branch
from
a83698b to
608e7db
Compare
asubiotto
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
|
@yuzefovich apologies I caused bors to get Canceled cause I forgot to wait for Github CI, you might have to give it another shot. |
|
@adityamaru no worries, thanks for letting me know. Sometimes I find myself in a similar boat and usually ping bors to merge the canceled PR myself. bors r+ |
TIL, will do next time! |
|
bors seems to have crashed bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #47473.
Release note: None