backupccl: direct spans after split and scatter #52241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
reviewed
Aug 3, 2020
dt
approved these changes
Aug 3, 2020
pbardea
force-pushed
the
split-and-scatter-dest
branch
from
3320ef9 to
9f81d95
Compare
|
Updated with a comment about why we only look at the first range. I also snuck in a change to ensure that when the chunks are split and scattered their leases are randomized. That part of the request was lost during the initial re-write to the processor. I would appreciate another look - thanks! |
dt
approved these changes
Aug 3, 2020
The AdminScatter request sent in the SplitAndScatterProcessor returns the lease information of the range after the scatter requst has completed. The SplitAndScatterProcessor now looks at this field to properly direct the spans to the appropriate RestoreData processor. Release note: None.
pbardea
force-pushed
the
split-and-scatter-dest
branch
from
9f81d95 to
2b5b45c
Compare
|
TFTR! |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AdminScatter request sent in the SplitAndScatterProcessor returns
the lease information of the range after the scatter requst has
completed. The SplitAndScatterProcessor now looks at this field to
properly direct the spans to the appropriate RestoreData processor.
Release note: None.