roachtest: remove confusing "--- PASS" log lines #52273
Conversation
|
This change is |
|
I don't think we should remove this. It's very useful to be able to quickly track through the search history of the test. Is it really that confusing? |
It is! It's the second time I see these lines and get confused. And I know my way around roachtest logs some... |
Well it just doesn't stand out at all, so it will make it hard to skim. Would changing |
Two workloads were printing PASS/FAIL lines from inside the predicates passed to Searcher.Search. This is really confusing when reading the test's output, because they don't correspond to the test's disposition. Release note: None
andreimatei
force-pushed
the
raochtest.fake-pass
branch
from
90031ed to
d1d27ba
Compare
There was a problem hiding this comment.
Went with --- SEARCH ITER {PASS,FAIL}.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @aayushshah15 and @nvanbenschoten)
There was a problem hiding this comment.
bors r+
Reviewable status:
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Two workloads were printing PASS/FAIL lines from inside the predicates
passed to Searcher.Search. This is really confusing when reading the
test's output, because they don't correspond to the test's disposition.
Release note: None