roachtest: reflake (skip) disk-stalled test for release-19.1 #52343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#52181. This test doesn't make use of all the `roachtest start` smartness to figure out what sub-command to use and instead constructs the raw start command by hand. Given our support policy, let's just bump the minimum version this test expects to run. This feels like another instance where cockroachdb#51897 would be nice to have. Release note: None
|
This change is |
petermattis
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten and @petermattis)
|
bors r+ |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52181. This test doesn't make use of all the
roachtest startsmartness to figure out what sub-command to use and instead constructs
the raw start command by hand.
Given our support policy, let's just bump the minimum version this test
expects to run. This feels like another instance where #51897 would be
nice to have.
Release note: None