-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add cgo compiler, os and arch info to version output #5766
Conversation
Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions. cli/cli.go, line 46 [r1] (raw file): util/build.go, line 25 [r1] (raw file): Comments from the review on Reviewable.io |
Reviewed 6 of 6 files at r1. cli/flags.go, line 480 [r1] (raw file): cli/cliflags/names.go, line 21 [r1] (raw file): util/build.proto, line 25 [r1] (raw file): util/build.proto, line 29 [r1] (raw file): util/build.proto, line 30 [r1] (raw file): Comments from the review on Reviewable.io |
937d952
to
9cb1e88
Compare
Review status: 0 of 7 files reviewed at latest revision, 7 unresolved discussions. cli/cli.go, line 46 [r1] (raw file): cli/flags.go, line 480 [r1] (raw file): cli/cliflags/names.go, line 21 [r1] (raw file): util/build.go, line 25 [r1] (raw file): util/build.proto, line 25 [r1] (raw file): util/build.proto, line 29 [r1] (raw file): util/build.proto, line 30 [r1] (raw file): Comments from the review on Reviewable.io |
Review status: 0 of 7 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed. util/build.go, line 25 [r2] (raw file): util/build.go, line 30 [r2] (raw file): Comments from the review on Reviewable.io |
Reviewed 7 of 7 files at r2. cli/flags.go, line 79 [r2] (raw file): Comments from the review on Reviewable.io |
also hide the dep versions unless requested with --all since they are usually captured by the tag thanks to glock, and thus just clutter up submitted issue reports. ``` $ ./cockroach version Build Tag: beta-20160331-dirty Build Time: 2016/03/31 14:42:04 Platform: darwin amd64 Go Version: go1.6 C Compiler: 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.29) ```
Review status: 5 of 9 files reviewed at latest revision, 3 unresolved discussions. util/build.go, line 25 [r2] (raw file): util/build.go, line 30 [r2] (raw file): Comments from the review on Reviewable.io |
Review status: 3 of 9 files reviewed at latest revision, 2 unresolved discussions. util/build.go, line 30 [r2] (raw file): Comments from the review on Reviewable.io |
Reviewed 6 of 6 files at r3. util/build.go, line 30 [r2] (raw file): util/build.proto, line 25 [r3] (raw file): Comments from the review on Reviewable.io |
Review status: all files reviewed at latest revision, 2 unresolved discussions. util/build.proto, line 25 [r3] (raw file): Comments from the review on Reviewable.io |
also hide the dep versions unless requested with --all since they are usually captured by the tag
thanks to glock, and thus just clutter up submitted issue reports.
This change is