Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: serve overview at /debug/ #5795

Merged
merged 2 commits into from
Apr 2, 2016
Merged

server: serve overview at /debug/ #5795

merged 2 commits into from
Apr 2, 2016

Conversation

tbg
Copy link
Member

@tbg tbg commented Apr 1, 2016

screen shot 2016-04-01 at 4 26 14 am

Did I miss anything?

This change is Reviewable

@petermattis
Copy link
Collaborator

There is also /_status/stacks/, though I'm wondering about the utility given the /pprof/goroutines endpoint. Perhaps it can be removed.

@petermattis
Copy link
Collaborator

LGTM

@nvanbenschoten
Copy link
Member

Nice! LGTM

@tbg
server: add TODO about removing stacks endpoint
53621bb 
It is mostly covered by /debug/pprof/goroutine.
@tbg
Copy link
Member Author

tbg commented Apr 2, 2016

Added a TODO on _status/stacks - maybe being able to get the goroutines by NodeID is useful, but hard to tell.

@tbg tbg merged commit 1bb565a into cockroachdb:master Apr 2, 2016
@tbg tbg deleted the debug-list branch April 2, 2016 08:59
@jseldess jseldess removed the docs-todo label May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbg @petermattis @nvanbenschoten @jseldess