sql: support FORCE_INDEX and NO_INDEX_JOIN hints #5806
Merged
+3,636
−3,340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review status: 0 of 13 files reviewed at latest revision, 2 unresolved discussions. sql/index_selection.go, line 179 [r1] (raw file): sql/parser/sql.y, line 3630 [r1] (raw file): Comments from the review on Reviewable.io |
Add support for `SELECT FROM table@{FORCE_INDEX=idx,NO_INDEX_JOIN}`, as
described in the index_hints RFC.
Closes cockroachdb#5625.
RaduBerinde
force-pushed
the
index-hint-strikes-back
branch
from
bc57d75 to
8bcd67a
Compare
|
TFTR! Updated. Review status: 0 of 13 files reviewed at latest revision, 2 unresolved discussions. Comments from the review on Reviewable.io |
|
Review status: 0 of 13 files reviewed at latest revision, 2 unresolved discussions. Comments from the review on Reviewable.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
SELECT FROM table@{FORCE_INDEX=idx,NO_INDEX_JOIN}, asdescribed in the index_hints RFC.
Closes #5625.
This change is