Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add packer config for builds triggered by public pull requests #58420

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

rickystewart
Copy link
Collaborator

This new config file is copied nearly verbatim from the existing one at
build/packer/teamcity-agent.json, except the GCP project is changed.

Release note: None

@rickystewart rickystewart requested a review from alan-mas January 4, 2021 17:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@alan-mas
Copy link
Contributor

alan-mas commented Jan 4, 2021

Nice, seems good to me.

Only that Teamcity build is failing, can you give a look on that? @rickystewart

@rickystewart
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 4, 2021

Build failed:

This new config file is copied nearly verbatim from the existing one at
`build/packer/teamcity-agent.json`, except the GCP project is changed.

Release note: None
@rickystewart
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 4, 2021

Build succeeded:

@craig craig bot merged commit 3ebe64c into cockroachdb:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants