roachprod: extend error reporting for DNS sync #59800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Related to cockroachdb#58905 In some cases `roachprod sync` fails updating the crdb.io DNS entries without giving enough information about the failure. It looks like the root cause may be the file format passed to the `gcloud dns` command. Added extra information in the error message in order to get a better picture when it happens again. Release note: None
knz
approved these changes
Feb 4, 2021
|
bors r=kena |
|
Build failed (retrying...): |
|
Looks like the merge run failed due the other PR in the same batch. Let's try again bors r=knz |
|
Already running a review |
|
bors retry |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #58905
In some cases
roachprod syncfails updating the crdb.io DNS entrieswithout giving enough information about the failure. It looks like the
root cause may be the file format passed to the
gcloud dnscommand.Added extra information in the error message in order to get a better
picture when it happens again.
Release note: None