-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geo/wkt: add support for parsing geometrycollections with Z and M dims #60515
Merged
craig
merged 1 commit into
cockroachdb:master
from
andyyang890:wkt_parse_geomcollection
Feb 19, 2021
Merged
geo/wkt: add support for parsing geometrycollections with Z and M dims #60515
craig
merged 1 commit into
cockroachdb:master
from
andyyang890:wkt_parse_geomcollection
Feb 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0177fc4
to
96fd935
Compare
otan
reviewed
Feb 12, 2021
96fd935
to
beeb0a5
Compare
otan
approved these changes
Feb 12, 2021
5e95bb1
to
c39dea5
Compare
c39dea5
to
d8bc797
Compare
otan
reviewed
Feb 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - thanks for the attention to detail here. my head hurts. owie.
most of my comments here are things we could comment better so the next person maintaining this doesn't struggle. also a few go-ism style nits.
3945930
to
933c5e7
Compare
otan
approved these changes
Feb 19, 2021
This patch extends the capabilities of the WKT parser to include parsing of geometrycollections with Z and M dimensions. Release note: None
933c5e7
to
163909d
Compare
bors r=otan |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the capabilities of the WKT parser to include
parsing of geometrycollections with Z and M dimensions.
Refs: #53091
Release note: None