Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo/wkt: add support for parsing geometrycollections with Z and M dims #60515

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

andyyang890
Copy link
Collaborator

This patch extends the capabilities of the WKT parser to include
parsing of geometrycollections with Z and M dimensions.

Refs: #53091

Release note: None

@andyyang890 andyyang890 requested a review from otan February 12, 2021 00:53
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 force-pushed the wkt_parse_geomcollection branch from 0177fc4 to 96fd935 Compare February 12, 2021 01:01
@andyyang890 andyyang890 force-pushed the wkt_parse_geomcollection branch from 96fd935 to beeb0a5 Compare February 12, 2021 03:30
@blathers-crl blathers-crl bot requested a review from otan February 12, 2021 03:30
@andyyang890 andyyang890 force-pushed the wkt_parse_geomcollection branch 2 times, most recently from 5e95bb1 to c39dea5 Compare February 18, 2021 04:02
@andyyang890 andyyang890 requested a review from otan February 18, 2021 04:09
@andyyang890 andyyang890 force-pushed the wkt_parse_geomcollection branch from c39dea5 to d8bc797 Compare February 18, 2021 04:39
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - thanks for the attention to detail here. my head hurts. owie.

most of my comments here are things we could comment better so the next person maintaining this doesn't struggle. also a few go-ism style nits.

@otan otan self-requested a review February 18, 2021 06:35
@andyyang890 andyyang890 force-pushed the wkt_parse_geomcollection branch 2 times, most recently from 3945930 to 933c5e7 Compare February 19, 2021 02:30
This patch extends the capabilities of the WKT parser to include
parsing of geometrycollections with Z and M dimensions.

Release note: None
@andyyang890 andyyang890 force-pushed the wkt_parse_geomcollection branch from 933c5e7 to 163909d Compare February 19, 2021 03:02
@andyyang890
Copy link
Collaborator Author

bors r=otan

@craig
Copy link
Contributor

craig bot commented Feb 19, 2021

Build succeeded:

@craig craig bot merged commit 83e70ce into cockroachdb:master Feb 19, 2021
@andyyang890 andyyang890 deleted the wkt_parse_geomcollection branch February 19, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants