sql: ensure graceful rollbacks if the ADD REGION async job fails #60762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
arulajmani
force-pushed
the
mr-add-region-failure
branch
from
c873c76 to
c5077a6
Compare
otan
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajstorm and @arulajmani)
pkg/sql/multiregion_test.go, line 205 at r1 (raw file):
if count != 1 { t.Fatal("expected crdb_internal_region to be present in system.namespace")
nit: delete
Previously, we assumed that the async component of an `ALTER DATABASE ... ADD REGION` wouldn't fail. This isn't really true though, because users may cancel jobs or we may be dropping regions in the same txn that fails validation. We have validation that ensures every region (READ ONLY or PUBLIC) on the multi-region type descriptor is also present on the database descriptor's region config (and vice-versa). If we realize that a region can't be promoted from READ ONLY to PUBLIC, we must also remove it from the database descriptor's region config (in addition removing it from the type descriptor). Prior to this patch we didn't do so, and cleanup could potentially fail validation. This patch fixes that behavior. This is a temporary band-aid until we stop denormalizing region values and have a single source of truth. Release note: None
arulajmani
force-pushed
the
mr-add-region-failure
branch
from
c5077a6 to
e654937
Compare
|
TFTR! bors r=otan |
arulajmani
changed the title
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we assumed that the async component of an
ALTER DATABASE ... ADD REGIONwouldn't fail. This isn't really truethough, because users may cancel jobs or we may be dropping regions in
the same txn that fails validation.
We have validation that ensures every region (READ ONLY or PUBLIC) on
the multi-region type descriptor is also present on the database
descriptor's region config (and vice-versa). If we realize that a region
can't be promoted from READ ONLY to PUBLIC, we must also remove it from
the database descriptor's region config (in addition removing it from
the type descriptor). Prior to this patch we didn't do so, and cleanup
could potentially fail validation. This patch fixes that behavior. This
is a temporary band-aid until we stop denormalizing region values and
have a single source of truth.
Release note: None