Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement ST_Z, ST_M, and ST_Zmflag #61032

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

andyyang890
Copy link
Collaborator

@andyyang890 andyyang890 commented Feb 23, 2021

This patch implements the geometry builtins ST_Z, ST_M,
and ST_Zmflag.

Resolves #60898.
Resolves #60899.
Resolves #60890.

Release justification: low-risk update to new functionality
Release note (sql change): The ST_Z, ST_M, and ST_Zmflag
builtins are now available for use.

@andyyang890 andyyang890 requested review from rafiss and otan February 23, 2021 23:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after fixing the tests

@andyyang890 andyyang890 force-pushed the st_zm_funcs branch 5 times, most recently from ba10a82 to d4d973d Compare March 1, 2021 21:04
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

This patch implements the geometry builtins `ST_Z`, `ST_M`,
and `ST_Zmflag`.

Release justification: low-risk update to new functionality
Release note (sql change): The `ST_Z`, `ST_M`, and `ST_Zmflag`
builtins are now available for use.
@andyyang890
Copy link
Collaborator Author

tftr! rebased to fix merge conflict

bors r=otan,rafiss

@craig
Copy link
Contributor

craig bot commented Mar 2, 2021

Build succeeded:

@craig craig bot merged commit 9ba4873 into cockroachdb:master Mar 2, 2021
@andyyang890 andyyang890 deleted the st_zm_funcs branch March 2, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants