-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builtins: implement ST_Z, ST_M, and ST_Zmflag #61032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otan
reviewed
Feb 23, 2021
andyyang890
force-pushed
the
st_zm_funcs
branch
from
February 24, 2021 00:43
695560f
to
2e03690
Compare
andyyang890
force-pushed
the
st_zm_funcs
branch
from
February 24, 2021 01:32
2e03690
to
0af803b
Compare
otan
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after fixing the tests
andyyang890
force-pushed
the
st_zm_funcs
branch
5 times, most recently
from
March 1, 2021 21:04
ba10a82
to
d4d973d
Compare
rafiss
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This patch implements the geometry builtins `ST_Z`, `ST_M`, and `ST_Zmflag`. Release justification: low-risk update to new functionality Release note (sql change): The `ST_Z`, `ST_M`, and `ST_Zmflag` builtins are now available for use.
tftr! rebased to fix merge conflict bors r=otan,rafiss |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the geometry builtins
ST_Z
,ST_M
,and
ST_Zmflag
.Resolves #60898.
Resolves #60899.
Resolves #60890.
Release justification: low-risk update to new functionality
Release note (sql change): The
ST_Z
,ST_M
, andST_Zmflag
builtins are now available for use.