pgwire: fix for specific cases of unnamed portal execution #83164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The Postgres docs say that an unnamed portal is automatically closed when a Bind command for another unnamed portal or a simple query is sent. We already implemented that for "normal" portals, but not for portals that were partially executed. This does not address the general case, but it does handle the common case that we see from tools like asyncpg. Release note (bug fix): Previously, executing an unnamed portal with a row count limit could encounter errors if another unnamed portal was opened. Now, CockroachDB correctly handles the common case of preparing and binding an unnamed portal by closing the existing unnamed portal. This matches the Postgres wire protocol.
rafiss
force-pushed
the
fix-unnamed-portal
branch
from
039faca to
bc502ed
Compare
rafiss
added
do-not-merge
6 tasks
|
closing since #40195 was resolved and eliminates the need for this workaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs MagicStack/asyncpg#580 (comment)
The Postgres docs say that an unnamed portal is automatically closed
when a Bind command for another unnamed portal or a simple query is
sent. We already implemented that for "normal" portals, but not for
portals that were partially executed.
This does not address the general case, but it does handle the common
case that we see from tools like asyncpg.
Release note (bug fix): Previously, executing an unnamed portal with a
row count limit could encounter errors if another unnamed portal was
opened. Now, CockroachDB correctly handles the common case of preparing
and binding an unnamed portal by closing the existing unnamed portal.
This matches the Postgres wire protocol.