teamcity: grep for pebble version in go.mod rather than DEPS.bzl
#83705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
ricky-test-pebblemeta
branch
from
4c81100 to
81649ce
Compare
nicktrav
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Thank you!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jbowens and @rickystewart)
build/teamcity/cockroach/nightlies/pebble_nightly_metamorphic.sh line 25 at r1 (raw file):
echo "$NEW_DEPS_BZL_CONTENT" > DEPS.bzl # Use the Pebble SHA from the version in the modified DEPS.bzl file.
nit: s/DEPS.bzl/go.mod/
The `grep` can fail in the case that there is no more recent version of `pebble` than the one that is vendored in-tree. This fixes that case. Release note: None
rickystewart
force-pushed
the
ricky-test-pebblemeta
branch
from
81649ce to
d412bce
Compare
jbowens
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
thanks!
Reviewable status:
|
TFTR! bors r=nicktrav,jbowens |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grepcan fail in the case that there is no more recent version ofpebblethan the one that is vendored in-tree. This fixes that case.Release note: None