sql: fix explain gist output to show number of scan span constraints #85325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
mgartner
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach and @rytaft)
pkg/sql/opt/exec/explain/testdata/gists line 1135 at r1 (raw file):
└── • scan table: ?@? spans: 15 spans
nit: add newline at end of file
rytaft
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
If there were span constraints we would always print 1, need to actually append them to get the count right. Fixes: cockroachdb#85324 Release note: None
cucaroach
force-pushed
the
gist-span-count
branch
from
e3be387 to
2a174ce
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there were span constraints we would always print 1, need to actually
append them to get the count right.
Fixes: #85324
Release note: None