lint: Add commit/PR body linter for epic and issue refs #87128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@jlinder This is ready for final review. My last Bazel run reached the 90 minute timeout, but I hope this one will succeed. |
jlinder
reviewed
Oct 4, 2022
jlinder
approved these changes
Oct 4, 2022
Before: Commits and PRs would inconsistently contain references to issues. Sometimes the author would forget to add it. Some authors might not think to add them. And there were no epic references provided. Why: Adding issue and epic references to PRs and commits provides traceability and context for the revenue teams, product, management and engineers. Now: A new GitHub Action workflow checks for references to issues the PR closes or informs and epics the PR is part of. It looks for references in the PR body and in commit messages and, if it doesn't find what it expects, it fails the check. Release note: None Release justification: Adding linter for epic tracking for engineering, docs, and internal teams.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: Commits and PRs would inconsistently contain references to issues.
Sometimes the author would forget to add it. Some authors might not
think to add them. And there were no epic references provided.
Why: Adding issue and epic references to PRs and commits provides
traceability and context for the revenue teams, product, management and
engineers.
Now: A new GitHub Action workflow checks for references to issues the PR
closes or informs and epics the PR is part of. It looks for references
in the PR body and in commit messages and, if it doesn't find what it
expects, it fails the check.
This PR is a continuation of #77654.
Fixes #77376
Release note: None
Release justification: Adding linter for better epic tracking