-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: backupccl: add 8TB TPCE restore nightly roachtest #91511
release-22.1: backupccl: add 8TB TPCE restore nightly roachtest #91511
Conversation
on the latest nightly 22.1 sha, the restore passes in 4.5 hours! CI failed on an unrelated flake. |
e222df6
to
50ac6d6
Compare
50ac6d6
to
c3771e7
Compare
RFAL! The test ran successfully in about 4.5 hours after running the roachtest from my gce worker. |
// running step only created another 100 GB of data. The backups did not begin | ||
// until after tpce init ended. | ||
// | ||
// Fixture recreation steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 do you want to check in the regeneration script so its trivial for future authors to regenerate it? Docs get moved and edited so I think this would be more future proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm, that's a good idea. There are bugs in my current script and I plan to fix it and check it in when i create 22.2 fixtures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one blocking comment about surfacing the actual job error for easier debugging.
bedb79b
to
b7978d1
Compare
This patch adds a nightly roachtest which conducts a 10TB restore of a backup created on a cluster running the TPC-E workload. Informs cockroachdb#91451 Release note: None
b7978d1
to
cb2cf15
Compare
This patch adds a nightly roachtest which conducts a 8TB restore of a backup created on a cluster running the TPC-E workload.
Informs #91451
Release note: None
Release justification: test only change