Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: backupccl: add 8TB TPCE restore nightly roachtest #91511

Merged

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Nov 8, 2022

This patch adds a nightly roachtest which conducts a 8TB restore of a backup created on a cluster running the TPC-E workload.

Informs #91451

Release note: None

Release justification: test only change

@msbutler msbutler self-assigned this Nov 8, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler
Copy link
Collaborator Author

msbutler commented Nov 8, 2022

on the latest nightly 22.1 sha, the restore passes in 4.5 hours!

CI failed on an unrelated flake.

@msbutler msbutler marked this pull request as ready for review November 9, 2022 01:23
@msbutler msbutler requested a review from adityamaru November 9, 2022 01:24
@adityamaru adityamaru self-requested a review November 9, 2022 20:57
@msbutler msbutler force-pushed the butler-restore-10TB-22-1 branch 2 times, most recently from e222df6 to 50ac6d6 Compare November 17, 2022 14:02
@msbutler msbutler force-pushed the butler-restore-10TB-22-1 branch from 50ac6d6 to c3771e7 Compare November 17, 2022 20:52
@msbutler
Copy link
Collaborator Author

RFAL! The test ran successfully in about 4.5 hours after running the roachtest from my gce worker.

pkg/cmd/roachtest/tests/restore.go Outdated Show resolved Hide resolved
// running step only created another 100 GB of data. The backups did not begin
// until after tpce init ended.
//
// Fixture recreation steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 do you want to check in the regeneration script so its trivial for future authors to regenerate it? Docs get moved and edited so I think this would be more future proof.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm, that's a good idea. There are bugs in my current script and I plan to fix it and check it in when i create 22.2 fixtures.

pkg/cmd/roachtest/tests/restore.go Outdated Show resolved Hide resolved
pkg/cmd/roachtest/tests/restore.go Outdated Show resolved Hide resolved
pkg/cmd/roachtest/tests/restore.go Outdated Show resolved Hide resolved
pkg/cmd/roachtest/tests/restore.go Show resolved Hide resolved
Copy link
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one blocking comment about surfacing the actual job error for easier debugging.

pkg/cmd/roachtest/tests/restore.go Outdated Show resolved Hide resolved
pkg/cmd/roachtest/tests/restore.go Outdated Show resolved Hide resolved
@adityamaru adityamaru self-requested a review November 28, 2022 16:40
@msbutler msbutler force-pushed the butler-restore-10TB-22-1 branch from bedb79b to b7978d1 Compare November 28, 2022 23:32
@adityamaru adityamaru changed the title backupccl: add 10TB TPCE restore nightly roachtest release-22.1: backupccl: add 10TB TPCE restore nightly roachtest Nov 29, 2022
This patch adds a nightly roachtest which conducts a 10TB restore of a backup
created on a cluster running the TPC-E workload.

Informs cockroachdb#91451

Release note: None
@msbutler msbutler force-pushed the butler-restore-10TB-22-1 branch from b7978d1 to cb2cf15 Compare November 29, 2022 02:18
@msbutler msbutler merged commit 798584d into cockroachdb:release-22.1 Nov 29, 2022
@msbutler msbutler deleted the butler-restore-10TB-22-1 branch November 29, 2022 13:44
@msbutler msbutler changed the title release-22.1: backupccl: add 10TB TPCE restore nightly roachtest release-22.1: backupccl: add 8TB TPCE restore nightly roachtest Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants