Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: split out separate test utils package #93470

Merged
merged 1 commit into from
Dec 13, 2022
Merged

backupccl: split out separate test utils package #93470

merged 1 commit into from
Dec 13, 2022

Conversation

jordanlewis
Copy link
Member

@jordanlewis jordanlewis commented Dec 12, 2022 •
edited
Loading

And add a test that ensures that cockroach doesn't import randgen.

Release note: None
Epic: None

@jordanlewis jordanlewis requested a review from a team as a code owner December 12, 2022 22:51
@jordanlewis jordanlewis requested review from rhu713 and removed request for a team December 12, 2022 22:51
@jordanlewis
Copy link
Member Author

cc @rytaft

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis jordanlewis mentioned this pull request Dec 12, 2022
Merged
rickystewart
rickystewart approved these changes Dec 12, 2022
View reviewed changes
pkg/BUILD.bazel Show resolved Hide resolved
@jordanlewis
backupccl: split out separate test utils package
5be363f 
And add a test that ensures that cockroach doesn't import randgen or
testcluster.

Release note: None
@jordanlewis
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 13, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 13, 2022

Build succeeded:

@craig craig bot merged commit 99e7bd7 into cockroachdb:master Dec 13, 2022
@mgartner
Copy link
Collaborator

This is cool! Thanks for doing this.

@jordanlewis jordanlewis deleted the backuptestutils branch December 13, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamaru adityamaru adityamaru left review comments

@rickystewart rickystewart rickystewart approved these changes

@dt dt dt approved these changes

@rhu713 rhu713 Awaiting requested review from rhu713 rhu713 was automatically assigned from cockroachdb/disaster-recovery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jordanlewis @cockroach-teamcity @mgartner @dt @rickystewart @adityamaru