Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade crlfmt, remove generics linter #93735

Merged
merged 2 commits into from
Dec 16, 2022
Merged

*: upgrade crlfmt, remove generics linter #93735

merged 2 commits into from
Dec 16, 2022

Conversation

ajwerner
Copy link
Contributor

This PR enables generics in cockroach.

Epic: none

Release note: None

@ajwerner ajwerner requested a review from a team as a code owner December 15, 2022 20:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner ajwerner mentioned this pull request Dec 15, 2022
Merged
@rickystewart
Copy link
Collaborator

Remove generics from list of linters in top-level BUILD.bazel

@ajwerner ajwerner force-pushed the ajwerner/enable-generics branch from 655a8bd to dbc0f01 Compare December 15, 2022 20:11
@ajwerner
Copy link
Contributor Author

Remove generics from list of linters in top-level BUILD.bazel

Done

@ajwerner ajwerner force-pushed the ajwerner/enable-generics branch from dbc0f01 to 62772a6 Compare December 15, 2022 20:27
knz
knz approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

@ajwerner
Copy link
Contributor Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 16, 2022

Build succeeded:

@craig craig bot merged commit 7fd3f09 into cockroachdb:master Dec 16, 2022
@erikgrinaker erikgrinaker mentioned this pull request Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz approved these changes

@rickystewart rickystewart rickystewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajwerner @cockroach-teamcity @rickystewart @knz