Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Make INT an alias for INT8 #4183

Closed
jseldess opened this issue Dec 17, 2018 · 0 comments
Closed

sql: Make INT an alias for INT8 #4183

jseldess opened this issue Dec 17, 2018 · 0 comments
Assignees
@rmloveland
Labels
C-product-change P-1 High priority; must be done this release
Milestone
19.1

Comments

@jseldess
Copy link
Contributor

PR: cockroachdb/cockroach#32831

From release notes:

The INT type is now treated as an alias for INT8. [#32831][#32831] {% comment %}doc{% endcomment %}
@jseldess jseldess added this to the 2.2 milestone Dec 17, 2018
@jseldess jseldess added the P-1 High priority; must be done this release label Dec 17, 2018
@rmloveland rmloveland mentioned this issue Jan 28, 2019
Open
rmloveland added a commit that referenced this issue Jan 30, 2019
@rmloveland
Update INT docs re: INT8, default_int_size setting
4d15404 
Fixes #4183, #4254.

Summary of changes:

- XXX
rmloveland added a commit that referenced this issue Jan 31, 2019
@rmloveland
Update INT docs re: INT8, default_int_size setting
e2fd572 
Fixes #4183, #4254.

Addresses part of #3420, #4298.

Summary of changes:

- Add `default_int_size` to session vars page

- Update `INT` data type page with new subsections of the **Size**
  section:

  - Description of compatibility issues caused by 64-bit integers
    vs. e.g. JavaScript runtimes, including when using autogenerated JS
    clients

  - Why you should avoid integer primary keys, with links to more
    information in Perf Best Practices and the Architecture docs
@rmloveland rmloveland mentioned this issue Feb 1, 2019
Closed
rmloveland added a commit that referenced this issue Feb 1, 2019
@rmloveland
Update INT docs re: INT8, default_int_size setting
c8c9fba 
Fixes #4183, #4254.

Lays some groundwork for future work on #4298.

Summary of changes:

- Add `default_int_size` to session vars page

- Update `INT` data type page with additions to the **Size**
  section, specifically:

  - A description of possible compatibility issues caused by 64-bit
    integers vs. e.g. JavaScript runtimes, including when using
    frameworks that autogenerate frontend code.

  - Mention and link to `default_int_size` session var and cluster
    setting.
rmloveland added a commit that referenced this issue Feb 1, 2019
@rmloveland
Update INT docs re: INT8, default_int_size setting
38f1e93 
Fixes #4183, #4254.

Lays some groundwork for future work on #4298.

Summary of changes:

- Update `INT` page to include examples of actual min/max integers
  supported by each type for easier reference.

- Update `INT` data type page with additions to the **Size**
  section, specifically:

  - A description of possible compatibility issues caused by 64-bit
    integers vs. e.g. JavaScript runtimes, including when using
    frameworks that autogenerate frontend code.

  - Mention and link to `default_int_size` session var and cluster
    setting.

- Add `default_int_size` to session vars page
@rmloveland rmloveland mentioned this issue Feb 1, 2019
Merged
rmloveland added a commit that referenced this issue Feb 1, 2019
@rmloveland
Update INT docs re: INT8, default_int_size setting
1df9b86 
Fixes #4183, #4254.

Lays some groundwork for future work on #4298.

Summary of changes:

- Update `INT` page to include examples of actual min/max integers
  supported by each type for easier reference.

- Update `INT` data type page with additions to the **Size**
  section, specifically:

  - A description of possible compatibility issues caused by 64-bit
    integers vs. e.g. JavaScript runtimes, including when using
    frameworks that autogenerate frontend code.

  - Mention and link to `default_int_size` session var and cluster
    setting.

- Add `default_int_size` to session vars page
rmloveland added a commit that referenced this issue Feb 4, 2019
@rmloveland
Update INT docs re: INT8, default_int_size setting
38e46b4 
Fixes #4183, #4254.

Lays some groundwork for future work on #4298.

Summary of changes:

- Update `INT` page to include examples of actual min/max integers
  supported by each type for easier reference.

- Update `INT` data type page with additions to the **Size**
  section, specifically:

  - A description of possible compatibility issues caused by 64-bit
    integers vs. e.g. JavaScript runtimes, including when using
    frameworks that autogenerate frontend code.

  - Mention and link to `default_int_size` session var and cluster
    setting.

- Add `default_int_size` to session vars page
rmloveland added a commit that referenced this issue Feb 6, 2019
@rmloveland
Update INT docs re: INT8, default_int_size setting
108f335 
Fixes #4183, #4254.

Lays some groundwork for future work on #4298.

Summary of changes:

- Update `INT` page to include examples of actual min/max integers
  supported by each type for easier reference.

- Update `INT` data type page with additions to the **Size**
  section, specifically:

  - A description of possible compatibility issues caused by 64-bit
    integers vs. e.g. JavaScript runtimes, including when using
    frameworks that autogenerate frontend code.

  - Mention and link to `default_int_size` session var and cluster
    setting.

- Add `default_int_size` to session vars page
@jseldess jseldess modified the milestones: 2.2, 19.1 Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
C-product-change P-1 High priority; must be done this release
Projects
None yet
Milestone
19.1
Development

No branches or pull requests
2 participants
@rmloveland @jseldess