Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new known limitations for 22.2 / Remove resolved limitations #15715

Merged
merged 12 commits into from
Dec 5, 2022

Conversation

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Nov 30, 2022

Files changed:

@netlify
Copy link

netlify bot commented Nov 30, 2022

Netlify Preview

Name Link
🔨 Latest commit 04c14ff
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/638e76101d84c600098e93f2
😎 Deploy Preview https://deploy-preview-15715--cockroachdb-docs.netlify.app/docs/v22.2/known-limitations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor Author

@mikeCRL mikeCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented asking specific would-be reviewers to review specific lines/subsections.

v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
@mikeCRL mikeCRL requested review from chengxiong-ruan and removed request for ajwerner December 2, 2022 18:29
v22.2/known-limitations.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the UDF limitations!

v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
@mikeCRL mikeCRL changed the title Add 22.2 known limitations Add 22.2 known limitations / Remove resolved known limitations Dec 5, 2022
@mikeCRL mikeCRL changed the title Add 22.2 known limitations / Remove resolved known limitations Add new known limitations for 22.2 Dec 5, 2022
@mikeCRL mikeCRL requested a review from lnhsingh December 5, 2022 21:21
Copy link
Contributor

@lnhsingh lnhsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just suggestions to add cross-links (if docs exist)

v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
v22.2/known-limitations.md Outdated Show resolved Hide resolved
@mikeCRL
Copy link
Contributor Author

mikeCRL commented Dec 5, 2022

Replicated the UDF limitations in the UDF doc.

v22.2/user-defined-functions.md

Follow up work will be to convert to includes, and reassess existing includes:

  • _includes/v22.2/known-limitations/udf-limitations.md
  • _includes/v22.2/known-limitations/udf-cdc-transformations.md

@mikeCRL mikeCRL force-pushed the known-limitations-v22.2 branch from 543d4f4 to 4210318 Compare December 5, 2022 22:11
@mikeCRL mikeCRL changed the title Add new known limitations for 22.2 Add new known limitations for 22.2 / Remove resolved limitations Dec 5, 2022
@mikeCRL mikeCRL merged commit 602af8f into master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants